Skip to content

L10n: third round of review fixes (function-name positions, CSV en-US, uk-UA decimals, per-app region) - #25

Merged
StDenis1980 merged 2 commits into
mainfrom
claude/project-thread-olo23h
Oct 30, 2026
Merged

StDenis1980 merged 2 commits into
mainfrom
claude/project-thread-olo23h

Conversation

@StDenis1980

Copy link
Copy Markdown
Owner

This PR brings the third round of review fixes from the upstream PRs (storytold#2820 and storytold#2822) into the fork.

Summary

  • A function name without parentheses is translated only where the evaluator expects a function: the LAMBDA argument of MAP, REDUCE, SCAN, BYROW, BYCOL and MAKEARRAY, and the aggregation argument of GROUPBY and PIVOTBY. SUMA(RAIZ;1) now keeps RAIZ as a name.
  • CSV import reads values with a new parse_file_input. It does not accept the euro and hryvnia forms (€5, 12,50 €, 250 грн), which only typed entry reads.
  • In uk-UA, 1 234.5 stays text. Before, it was read as 1234.5.
  • SheetApp::logic and SheetApp::ui each run in the app's own display region and restore the thread's region afterwards. Two apps on one thread no longer show values in each other's region.

Tests

New tests are in spanish_input.rs, regional_input.rs, csv_tests.rs and the ui-egui formula_locale.rs; the last one interleaves frames from two apps on one thread. I checked that the function-name, CSV and two-app tests fail with their fix reverted. The uk-UA check was not run against a revert.

Results: the core, formula, xlsx and engine suites are green, and fmt and clippy -D warnings are clean. ui-egui has two failures, the same two that fail on main in this container because there is no ẞ font.


Generated by Claude Code

…ected

Review of storytold#2820 (CodeRabbit, Harrison-Booth): SUMA(RAIZ;1) became
SUM(SQRT,1). A bare name is now translated only in the positions the
evaluator reads as a function (the LAMBDA of MAP, REDUCE, SCAN, BYROW,
BYCOL and MAKEARRAY, the aggregation of GROUPBY and PIVOTBY); every other
argument, and LAMBDA invocation arguments, keep the name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0147pTEvxKfh4hi3my35jsAg
…per app frame

Review of storytold#2822 (CodeRabbit, Harrison-Booth):
- CSV import reads values with parse_file_input, without the euro and
  hryvnia forms only typed entry reads.
- In uk-UA, 1 234.5 mixes two conventions and stays text rather than
  being read as 1234.5.
- SheetApp::logic and ::ui each run in the app's region and put the
  thread's region back afterwards, so two apps sharing a thread never show
  values in each other's region (interleaving regression test).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0147pTEvxKfh4hi3my35jsAg
@StDenis1980
StDenis1980 merged commit 05a9210 into main Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants